Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/getkin/kin-openapi to v0.98.0 #180

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 30, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/getkin/kin-openapi require minor v0.94.0 -> v0.98.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependency label May 30, 2022
@renovate renovate bot changed the title Update module github.com/getkin/kin-openapi to v0.95.0 Update module github.com/getkin/kin-openapi to v0.96.0 May 31, 2022
@renovate renovate bot force-pushed the renovate/gh.neting.cc-getkin-kin-openapi-0.x branch from 2642238 to dfdfab5 Compare May 31, 2022 17:14
@renovate renovate bot changed the title Update module github.com/getkin/kin-openapi to v0.96.0 Update module github.com/getkin/kin-openapi to v0.97.0 Jun 12, 2022
@renovate renovate bot force-pushed the renovate/gh.neting.cc-getkin-kin-openapi-0.x branch from dfdfab5 to 1c4ba0a Compare June 12, 2022 13:02
@renovate renovate bot force-pushed the renovate/gh.neting.cc-getkin-kin-openapi-0.x branch 5 times, most recently from 6b074ca to 88da881 Compare July 31, 2022 17:23
@renovate renovate bot changed the title Update module github.com/getkin/kin-openapi to v0.97.0 Update module github.com/getkin/kin-openapi to v0.98.0 Jul 31, 2022
@renovate renovate bot force-pushed the renovate/gh.neting.cc-getkin-kin-openapi-0.x branch 3 times, most recently from 3978d12 to 5798ca4 Compare August 3, 2022 07:16
@glrf
Copy link
Contributor

glrf commented Aug 3, 2022

We remove the GitRepo Type default from the specification.

Our OpenAPI validation library added support for default values. This includes a feature/bug that fails the validation if defaults are set for merge-patch+json requests.

We currently define a GitRepo type default of auto . This is defined across all requests and responses. However this is arguably wrong for patches. When patching a resource we generally don't want to set default as this will lead to unexpected results (i.e. reverting to the default if we do not explicitly set it to the current value in the patch)

For this reason (and to fix the validation error) we remove the GitRepo type default from the specification.

The "more correct" solution would probably be to keep the default and add a different specification without the default for patch operations, but that would make the OpenAPI specification a lot harder to maintain, so I opted for the technically wrong solution.

renovate bot and others added 2 commits August 3, 2022 11:12
Our OpenAPI validation library added support for default values. This
includes a feature/bug that fails the validation if defaults are set for
`merge-patch+json` requests.

We currently define a GitRepo type default of `auto` . This is defined
across all requests and responses. However this is arguably wrong for
patches. When patching a resource we generally don't want to set default
as this will lead to unexpected results (i.e. reverting to the default
if we do not explicitly set it to the current value in the patch)

For this reason (and to fix the validation error) we remove the GitRepo
type default from the specification.
@glrf glrf force-pushed the renovate/gh.neting.cc-getkin-kin-openapi-0.x branch from 76555c8 to 02cb3c2 Compare August 3, 2022 09:12
@glrf glrf requested review from bastjan and simu August 3, 2022 09:17
@glrf glrf merged commit 822db21 into master Aug 3, 2022
@glrf glrf deleted the renovate/gh.neting.cc-getkin-kin-openapi-0.x branch August 3, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants